Talk:Signing bug

From WiiBrew
Jump to navigation Jump to search

"NULL" should be spelled "NUL" in this context. "NULL" in C refers to a special pointer value, while "NUL" is a zero ASCII character value.

NULL is OK --Pepsiman 09:55, 26 March 2008 (PDT)

That's it?

That's the big singing bug? Some genius used strncmp instead of memcmp to compare binary data? ROFL. 11:41, 27 March 2008 (PDT)

I'm afraid so. Also, they didn't bother checking any of the padding, either -- which would have at least made it much more difficult to exploit. Bushing 14:00, 27 March 2008 (PDT)

Code example

Well, I don't want to start a revert war against an admin. That's stupid. I preffer to keep my ban wars on IRC.

I think that my example gets the point out, the point isn't to be exact in what the IOS code does, the point is to show an example of how this class of bugs looks like. While I can't deny the fact that bushing's code is much more real, it hides the point of the example code by being too big. It's a lot of cruff and largely a pain to figure out where the bug is. I think that clarity is better than realism here.--henke37 13:29, 16 July 2008 (CEST)

The other signing bug

Is the fixed padding bug still a thing as well? Hallowizer (talk) 23:27, 25 May 2021 (CEST)