Talk:MLlib/Archive 1

From WiiBrew
Jump to: navigation, search

[Old] "GPL" Problem

I just checked the code, it near an entire code ripping from GRRLIB (http://grrlib.santo.fr) !! Ripping is so lame... without any credits.... --NoNameNo 21:21, 21 June 2009 (UTC) —Preceding undated comment added 00:48, 21 June 2009 (UTC).

Are you just kidding me ? When the code is "ripped" like you say, I say it ! And credits are there. Just read before say. --Minishlink 09:05, 21 June 2009 (UTC)

GPL Violation

Portions of your code were taken/modified from other libraries. For example, a large amount of ML_video.c clearly originates from GRRLIB. This is fine (this is the point of open source), but you must credit the code sources properly - "Special Thanks" is not sufficient. Each source file and/or function should have the original authors credited, and you should be more specific in your readme that code credit is due to others (and to whom for what). If you fail to comply, MLlib will be removed from WiiBrew. --Tantric 20:55, 28 June 2009 (UTC)

Roger that. I will credit it properly when I'll be at home - 12th of July - I didn't know it wasn't sufficient and I apologize for that. --Minishlink 06:20, 30 June 2009 (UTC)

It will take some more time, I'm not at home until the end of August, sorry guys ! --Minishlink 10:44, 7 August 2009 (UTC)

Here's the usage agreement from the readme.txt in GRRlib 4.0. How hard is it for you to simply mention GRRLib in your THANKS text file?--Michael 15:59, 7 August 2009 (UTC)
  GRRLIB is NOT provided under any shitty license.

  If you use it, we only ask to :
  - dont forget us in the credits !!
  - to display the grrlib logo in you product as it's possible
How is it a GPL-violation, when GRRlib is not GPL licensed...? --Mechaelvis 13:22, 25 August 2009 (UTC)

Anyway, I finally clarified that point in my library, yipiiie ! (well, can I have my page back please ? :/ ) --Minishlink 19:53, 27 August 2009 (UTC)

Thank you Tantric :) --Minishlink 21:00, 27 August 2009 (UTC)

Thanx from the GRRLib Team

big thanks to you tantric for this clarification, there is a lot of more than the ML_video.c concerning GRRLib, but i bet that lot of other lines are direct copy/past from other libs. Minishlink should at least code a real wrapper, i mean let original library and code in mllib project, and only code a wrapper without "renaming" original lib functions names. There is even not the word GRRLib on the wiibrew page of mllib. Let me "re add" the "Homebrew using GRRLib" category. --NoNameNo 07:17, 30 June 2009 (UTC)

That's fine to add the category if you want. But you don't seem to understand that my lib is a framework first of all, the name of the functions have to be comprehensible and so on : I think it'd be very confusing to suddenly have a GRRLIB_Something which you don't know where it comes from... and anyway I modified the functions, so I can't leave it as it was in your lib... Sorry. One more thing please, all the things that I "copied/pasted" like you love to say are open-source : it means I can take some of your functions and include them into my lib, and then modify them... I just didn't pay enough attention for that credits thing, it's seriously boring to do these things but I swear it will be done for the next release. --Minishlink 05:06, 1 July 2009 (UTC)

i don't want to start a drama like, but it should be so easy to add GRRLIB to your framework project, then only code a wrapper ( MLlib_yourfunction calling GRRLIB_our ) and all could be respected without any problem ;) and to finnish, remember that open source is a philosophy based upon respect and sharing !!! --NoNameNo 16:31, 1 July 2009 (UTC)

Problem with Makefile

the Makefile has a very bugged make clean. it is using /include instead of include which can cause major issues. fix this before others suffer the same fate I did. Megazig 02:45, 15 October 2009 (UTC)

It's not very clear... Are you talking about the template Makefile or the MLlib Makefile ? The template Makefile do that when "make clean" : "rm -fr $(BUILD) $(OUTPUT).elf $(OUTPUT).dol" -> It's not deleting /include... And for the MLlib Makefile, it DOES delete include but it's my will : the MLlib folder is the release, and the MLlib_ folder is the source, compile from de MLlib_ and you will get your new MLlib. -- Minishlink —Preceding unsigned comment added by Minishlink (talkcontribs) 05:45, 15 October 2009 (UTC)

on a *nix system, / is the root of the filesystem, so /include is the include directory on the root NOT the include directory in the MLlib directory or wherever. afaict this is what megazig is complaining about. --Yossi 07:18, 15 October 2009 (UTC)
thank you Yossi. that is exactly what I'm talking about. you use /include which is the include folder on the root of a *nix system. delete that and mess up a system. Very poor Makefile. it's the poor use of MLPATH with not setting it, and not telling to set it in a README that's just piss poor.
Here's what your absolutely terrible Makefile does.

megazig@megazig-desktop mllib % make clean 5:09:55
make: /home/megazig/devkitpro/devkitPPC/bin/powerpc-eabi-gcc: Command not found
rm -fr /include
rm -fr /lib
rm: cannot remove `/lib/libpcsclite.so.1.0.0': Permission denied
rm: cannot remove `/lib/libthread_db.so.1': Permission denied
rm: cannot remove `/lib/udev/scsi_id': Permission denied
rm: cannot remove `/lib/udev/fstab_import': Permission denied
rm: cannot remove `/lib/udev/usb_id': Permission denied
rm: cannot remove `/lib/udev/firmware.sh': Permission denied
rm: cannot remove `/lib/udev/pcmcia-check-broken-cis': Permission denied Megazig 10:15, 15 October 2009 (UTC)

So you're talking about the MLlib Makefile... You know I'm programming on Linux ? I don't have that problem. Anyway, there's nothing deleted because of the protection, right ? I thought I've spoken about the env variable, I'm confused. I'm going to add it to the README. ;) Thanks for the feedback ! --Minishlink 14:32, 15 October 2009 (UTC)