Changes

31 bytes added ,  02:53, 6 December 2019
→‎Version history: Doesn't look like group B actually changed partition behavior, with 90% certainty (it's hard to check completely)
Line 257: Line 257:  
doBlockRead prints "(doBlockRead) Data subblock %d failed to verify against H0 Hash" instead of "(doBlockRead) Data failed to verify against H0 Hash" if a hash fails.  Note that the subsequent call to diFatalError still uses the old message.  Additionally, the coutner for the loop changed direction since it can show up in that message (presumably a compiler optimisation no longer being possible, instead of an actual change).
 
doBlockRead prints "(doBlockRead) Data subblock %d failed to verify against H0 Hash" instead of "(doBlockRead) Data failed to verify against H0 Hash" if a hash fails.  Note that the subsequent call to diFatalError still uses the old message.  Additionally, the coutner for the loop changed direction since it can show up in that message (presumably a compiler optimisation no longer being possible, instead of an actual change).
   −
Partition-related code seems to have changed{{check}} (printing less messages, among other things), but it's hard to make sense of what's an actual change versus code that was only added for the new IoctlVs.
+
Partition-related code was split into several functions (and fewer functions are now inlined), due to the addition of functions for the new IoctlVs.  Actual behavior seems to be identical, apart from log messages using new function names.
    
Removed a variable that stored the H3 hashes offset that was never read (previously located at 20233df4).  However, they didn't remove an even more useless H3 hashes size variable right after it (previously at 20233df8, now at 2022ddb4), for some reason.
 
Removed a variable that stored the H3 hashes offset that was never read (previously located at 20233df4).  However, they didn't remove an even more useless H3 hashes size variable right after it (previously at 20233df8, now at 2022ddb4), for some reason.
303

edits